[Skiboot] [PATCH V7 03/12] errorlog: Removal of elog_reject_head() from 'opal_kexec_elog_notify' routine

Mukesh Ojha mukesh02 at linux.vnet.ibm.com
Tue Nov 15 21:06:08 AEDT 2016


Hi Stewart,


On Friday 11 November 2016 11:24 AM, Mukesh Ojha wrote:
>
>
> On Tuesday 25 October 2016 03:03 PM, Stewart Smith wrote:
>> Mukesh Ojha <mukesh02 at linux.vnet.ibm.com> writes:
>>> elog_reject_head() routine makes the state 
>>> 'elog_read_from_fsp_head_state'
>>> either 'ELOG_STATE_REJECTED' or 'ELOG_STATE_NONE' depending on the 
>>> current
>>> state of 'elog_read_from_fsp_head_state'.
>>>
>>> We can remove this elog_reject_head() from 
>>> 'opal_kexec_elog_notify()' as just
>>> after that it is called inside 'fsp_opal_resend_pending_logs()'. So, 
>>> it is
>>> redundant inside opal_kexec_elog_notify() routine.
>>>
>>> Signed-off-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>
>>> Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> I've pulled in the first three patches to master as of
>> ee1bbae31c50bdc260a0d3e0eed33114155f0044 and plan to look at the rest
>> closely tomorrow - my brain is fried after another long day today (see
>> the patches r.e. secure/trusted boot headers).
>>
>
> Hi Stewart,
>
> Can you please try to review remaining patches of this series O:-) ?
>
> ~Mukesh

Rebasing the remaining patches of this series on top of master.
Please review the V8.

~Mukesh

>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot



More information about the Skiboot mailing list