[Skiboot] [PATCH 2/4] external: Remove -m64 from shared CFLAGS on ARM

Patrick Williams patrick at stwcx.xyz
Fri May 27 00:33:30 AEST 2016


On Wed, May 25, 2016 at 09:54:29PM -0400, Brad Bishop wrote:
> -m64 isn't an ARM flag.
> 
> Signed-off-by: Brad Bishop <bradleyb at fuzziesquirrel.com>
> ---
>  external/shared/Makefile | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/external/shared/Makefile b/external/shared/Makefile
> index 40ba2b9..b96c662 100644
> --- a/external/shared/Makefile
> +++ b/external/shared/Makefile
> @@ -8,7 +8,10 @@ INCDIR = $(PREFIX)/include/libflash
>  
>  VERSION = $(shell ../../make_version.sh)
>  
> -CFLAGS += -m64 -Werror -Wall -g2 -ggdb -I. -fPIC
> +ifneq ($(ARCH), ARCH_ARM)
> +CFLAGS += -m64
> +endif

Should this be done only on Power?  I'm not sure why it is even required
there because you typically have a prefixed cross-compiler (ex.
powerpc64-...gcc).

> +CFLAGS += -Werror -Wall -g2 -ggdb -I. -fPIC
>  
>  LIBFLASH_OBJS = libflash-file.o libflash-libflash.o libflash-libffs.o libflash-ecc.o libflash-blocklevel.o
>  ARCHFLASH_OBJS = common-arch_flash.o
> -- 
> 2.7.4 (Apple Git-66)
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20160526/00e11f47/attachment.sig>


More information about the Skiboot mailing list