[Skiboot] [PATCH 1/2] phb3: Refactor to move capi enable to it's own function

Andrew Donnellan andrew.donnellan at au1.ibm.com
Wed May 25 17:46:50 AEST 2016

On 24/05/16 21:22, Ian Munsie wrote:
> From: Ian Munsie <imunsie at au1.ibm.com>
> The phb3_set_capi_mode function was getting a little long, and the
> enable procedure will need to be parameterised to support CAPP DMA mode,
> so split it out into it's own function in preparation for this. Also
> replace the multiple if (mode == xxx) cases with an equivalent switch
> construct since it will shortly gain yet another case.
> No functional changes.
> Signed-off-by: Ian Munsie <imunsie at au1.ibm.com>

Looks good to me (apart from the two extraneous apostrophes in the title 
and commit message ;)

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list