[Skiboot] [PATCH v2 4/7] test/hello_world: Call OPAL_CEC_POWER_DOWN at end

Michael Neuling mikey at neuling.org
Tue May 10 16:32:47 AEST 2016


On Tue, 2016-05-10 at 16:22 +1000, Stewart Smith wrote:
> Michael Neuling <mikey at neuling.org> writes:
> > 
> > Call OPAL_CEC_POWER_DOWN at end rather than using a raw attn
> > instruction. We are doing this since attn should be disabled in the
> > host kernel otherwise userspace may crash the machine by calling it.
> > 
> > We are now doing two opal calls so need to save some registers which
> > are volatile over opal calls.
> > 
> > This bloats the code from 10 instructions up to 16. May god have mercy
> > on my soul.
> > 
> > Signed-off-by: Michael Neuling <mikey at neuling.org>
> > ---
> >  test/hello_world/hello_kernel/hello_kernel.S | 20 +++++++++++++++++---
> >  1 file changed, 17 insertions(+), 3 deletions(-)
> Merged as of 591feee. I also modified the test/run_mambo_hello_world.sh
> script so that it looked for the clean shutdown rather than ATTN.

OK.  Thanks.

Mikey


More information about the Skiboot mailing list