[Skiboot] [PATCH v10 16/17] core/opal: Use PCI slot and new APIs for slot states

Gavin Shan gwshan at linux.vnet.ibm.com
Fri May 6 11:15:11 AEST 2016

On Fri, May 06, 2016 at 11:03:35AM +1000, Andrew Donnellan wrote:
>On 03/05/16 15:04, Gavin Shan wrote:
>>The various reset requests are completed by PHB's callbacks. All
>>of them (except reset on IODA table or error injection) are covered
>>by PCI slot. opal_pci_poll() faces similar situation.
>>This reimplements opal_pci_reset() and opal_pci_poll() based on
>>the callbacks provided by PCI slot instead of PHB. Also, couple of
>>new APIs are introduced based on the callbacks in PCI slot as below:
>>    * opal_pci_get_presence_state(): Check if there is adapter presented
>>      behind the specified PHB or PCI slot.
>>    * opal_pci_get_power_state(): Returns power supply state (on or off)
>>      on the specified PHB or PCI slot.
>>    * opal_pci_set_power_state(): Sets power supply state (on or off)
>>      on the specified PHB or PCI slot.
>I notice that the name of the OPAL calls are {get,set}_power_state(), while
>the callbacks are called {get,set}_power_status(). IMHO they should be made

Thanks for review. Yes, I will make all of them to have suffix _state().



>Andrew Donnellan              OzLabs, ADL Canberra
>andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list