[Skiboot] [PATCH] external/pflash: Handle incorrect cmd-line options better

Stewart Smith stewart at linux.vnet.ibm.com
Tue May 3 19:10:06 AEST 2016

Cyril Bur <cyril.bur at au1.ibm.com> writes:

> The current pflash cmd-line option parsing has two flaws.
> Firstly, the error reporting leaves quite a bit to be desired. That is, when
> invalid options or argument are found, not much reporting is done. This patch
> addresses this.
> Secondly, pflash doesn't detect when there are leftovers in argv. This often
> signals a typo in what the user meant to do and could lead to the wrong
> outcome. For example: `pflash -e -p zImage.next - P BOOTKERNEL` will do quite
> the wrong thing.
> This patch addresses both issues.
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> ---
>  external/pflash/pflash.c | 33 +++++++++++++++++++++++++++------
>  1 file changed, 27 insertions(+), 6 deletions(-)

Merged to master as of 1abcd49

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list