[Skiboot] [PATCH] Allow warnings conditionally.

[Stewart Smith]

Michael Neuling <mikey at neuling.org> writes:
> On Wed, 2016-04-20 at 15:52 +1000, Russell Currey wrote:
>> On Wed, 2016-04-20 at 10:34 +1000, Alastair D'Silva wrote:
>> > When building in CI, we want to see all potential problems noted by
>> > compilers & static analysers that masquerade as a compiler, rather than
>> > halting on the first one.
>> > This is especially important as we tend to implement
>> > different/stricter/expensive checks compared to a typical compiler, and
>> > as such, these may not be visible when performing a normal build.
>> > 
>> > This patch conditionally allows compiler warnings by passing
>> > ALLOW_WARNINGS=1 as a make variable. The default behavior remains to
>> > fault on the first warning.
>> > 
>> > Signed-off-by: Alastair D'Silva <alastair at d-silva.org>
>> > ---
>> 
>> This patch doesn't apply to master or stable:
>> 
>> 	Applying: Allow warnings conditionally.
>> 	fatal: corrupt patch at line 13
>> 
>> which is strange.  I like the idea, though.
>
> The headers suggest it was sent via IBM mail routers, so it could
> be them playing white space tricks again.

While blaming IBM mail infrastructure is almost by default correct, in
this case it may be the MUA - Evolution seems to have been butchering
things recently - there were a few corrupted ones from benh a little
while ago.

I'd suggest git-send-email :)

-- 
Stewart Smith
OPAL Architect, IBM.