[Skiboot] [PATCH V3 1/6] fsp: Add CAPP lid definition for Naples

[Michael Neuling]

On Thu, 2016-03-31 at 15:16 +1100, Stewart Smith wrote:
> Philippe Bergheaud <felix at linux.vnet.ibm.com> writes:
> > Signed-off-by: Philippe Bergheaud <felix at linux.vnet.ibm.com>
> > 
> > Reviewed-by: Michael Neuling <mikey at neuling.org>
> > ---
> > V2, V3: no changes
> > 
> >  hw/fsp/fsp.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c
> > index 26ae71e..7a534b9 100644
> > --- a/hw/fsp/fsp.c
> > +++ b/hw/fsp/fsp.c
> > @@ -2260,6 +2260,7 @@ int fsp_fetch_data_queue(uint8_t flags, uint16_t id, uint32_t sub_id,
> >  #define CAPP_IDX_VENICE_DD20 0x200ea
> >  #define CAPP_IDX_MURANO_DD20 0x200ef
> >  #define CAPP_IDX_MURANO_DD21 0x201ef
> > +#define CAPP_IDX_NAPLES_DD21 0x100d3
> 
> DD1.0 ?

ACK, should be named CAPP_IDX_NAPLES_DD10.  Please update philippe.

> 
> >  static struct {
> >  	enum resource_id	id;
> > @@ -2272,6 +2273,7 @@ static struct {
> >  	{ RESOURCE_ID_CAPP,	CAPP_IDX_MURANO_DD21,	0x80a02001 },
> >  	{ RESOURCE_ID_CAPP,	CAPP_IDX_VENICE_DD10,	0x80a02003 },
> >  	{ RESOURCE_ID_CAPP,	CAPP_IDX_VENICE_DD20,	0x80a02004 },
> > +	{ RESOURCE_ID_CAPP,	CAPP_IDX_NAPLES_DD21,	0x80a02005 },
> >  };
> 
> Do we have any FSP machines with Naples chips? Has this ever been tested?

No and no.  But this is the lid number that was assigned for the
Naples ucode lid. 

So it's untested but I'd be tempted to put it in as it's likely
right anyway.  :-D

Mikey