[Skiboot] [PATCH v4 5/6] hdata/hdata_to_dt: Add -s option

[Michael Neuling]

On Tue, 2016-03-29 at 10:58 +0530, Vasant Hegde wrote:
> On 03/23/2016 05:38 AM, Michael Neuling wrote:
> > On Tue, 2016-03-22 at 11:18 +0530, Vasant Hegde wrote:
> > 
> > > hdata_to_dt handles legacy SPIRA data only. This patch adds
> > > new option (-s) to handle new SPIRAH/S data.
> > 
> > Why not just auto detect it for the user based on the header, rather
> > than making them add this option?
> > 
> > eg:
> >    if (spiras->hdr == SPIRAS_HDIF_SIG)
> > 	new_spira = true;
> 
> Mikey,
> 
> I had thought about this.. We can add validation to SPIRAS data.. But then in 
> case of legacy SPIRA, we can't validate SPIRA HEAP area. 

Why not?  Can't just auto detect it as a legacy SPIRA and then do the
SPIRA HEAP validation?

> So I thought of 
> introducing new option. Also this is just test cases used by developers mostly ;-)
> 
> If you still insist I can revert this change and add validation. Not a big deal. 
> Let me know you.

I'd really prefer it auto detected. Why leave it to the user when the
program can do it easily.

Mikey

> 
> -Vasant
>