[Skiboot] [PATCH V2 2/7] pci: Add for_each_phb macro for PHB traversal

Andrew Donnellan andrew.donnellan at au1.ibm.com
Mon Mar 21 14:13:40 AEDT 2016


On 21/03/16 12:00, Russell Currey wrote:
> Similar to for_each_cpu, adding a for_each_phb makes PHB traversal easy.
>
> Suggested-by: Alistair Popple <alistair at popple.id.au>
> Signed-off-by: Russell Currey <ruscur at russell.cc>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

> @@ -513,6 +514,7 @@ static inline int64_t pci_cfg_write32(struct phb *phb, uint32_t bdfn,
>   }
>
>   /* Utilities */
> +
>   extern int64_t pci_find_cap(struct phb *phb, uint16_t bdfn, uint8_t cap);

Extraneous whitespace, please submit V3 ;)

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list