[Skiboot] [PATCH] Move ipmi-opal.c from hw/ipmi to core

Alistair Popple alistair at popple.id.au
Thu Mar 17 15:33:26 AEDT 2016


Thanks! This has been on my list of clean ups for a while (I should really have put it in core 
in the first place), but I'll leave it to Stewart to decide if it's worth doing now or not.

Acked-by: Alistair Popple <alistair at popple.id.au>

On Tue, 15 Mar 2016 15:53:54 Vasant Hegde wrote:
> ipmi-opal.c contain OPAL API related functions. Commit a561cf7b added IPMI
> support for FSP based system. Now FSP and AMI BMC based system makes use of
> these functions. Hence move this file from hw specific dir to core dir.
> 
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
> @Stewart,
>   Feel free to ignore this patch, if you think its fine to keep this file
>   under hw/ipmi.
> 
> -Vasant
> 
>  core/Makefile.inc    |    2 -
>  core/ipmi-opal.c     |  141 
++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/ipmi/Makefile.inc |    2 -
>  hw/ipmi/ipmi-opal.c  |  141 --------------------------------------------------
>  4 files changed, 143 insertions(+), 143 deletions(-)
>  create mode 100644 core/ipmi-opal.c
>  delete mode 100644 hw/ipmi/ipmi-opal.c
> 
> diff --git a/core/Makefile.inc b/core/Makefile.inc
> index 83370c1..5af0d7c 100644
> --- a/core/Makefile.inc
> +++ b/core/Makefile.inc
> @@ -7,7 +7,7 @@ CORE_OBJS += timebase.o opal-msg.o pci.o pci-opal.o fast-reboot.o
>  CORE_OBJS += device.o exceptions.o trace.o affinity.o vpd.o
>  CORE_OBJS += hostservices.o platform.o nvram.o nvram-format.o hmi.o
>  CORE_OBJS += console-log.o ipmi.o time-utils.o pel.o pool.o errorlog.o
> -CORE_OBJS += timer.o i2c.o rtc.o flash.o sensor.o
> +CORE_OBJS += timer.o i2c.o rtc.o flash.o sensor.o ipmi-opal.o
>  
>  ifeq ($(SKIBOOT_GCOV),1)
>  CORE_OBJS += gcov-profiling.o
> diff --git a/core/ipmi-opal.c b/core/ipmi-opal.c
> new file mode 100644
> index 0000000..1b28aa6
> --- /dev/null
> +++ b/core/ipmi-opal.c
> @@ -0,0 +1,141 @@
> +/* Copyright 2013-2014 IBM Corp.
> + *
> + * Licensed under the Apache License, Version 2.0 (the "License");
> + * you may not use this file except in compliance with the License.
> + * You may obtain a copy of the License at
> + *
> + * 	http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> + * implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +
> +#include <stdlib.h>
> +#include <string.h>
> +#include <ipmi.h>
> +#include <lock.h>
> +#include <opal.h>
> +#include <device.h>
> +#include <ccan/list/list.h>
> +
> +static struct lock msgq_lock = LOCK_UNLOCKED;
> +static struct list_head msgq = LIST_HEAD_INIT(msgq);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20160317/0acdeb55/attachment-0001.html>


More information about the Skiboot mailing list