[Skiboot] [PATCH v8 0/7] OPAL support for Nest instrumentation

[Michael Neuling]

Maddy,

>                 chip at 7fdb20000 {
>                         ibm,chip-id = <0x0>;
>                         ranges = <0x0 0x7 0xfdb20000 0x30000>;

Should this be a reg property?


>                         #address-cells = <0x1>;
>                         phandle = <0x100001e1>;
>                         #size-cells = <0x1>;
>                         linux,phandle = <0x100001e1>;
> 
>                         mcs {
>                                 compatible = "ibm,nest-counters
> -chip";
>                                 ranges;
>                                 #address-cells = <0x1>;
>                                 phandle = <0x100001e2>;
>                                 #size-cells = <0x1>;
>                                 linux,phandle = <0x100001e2>;
> 
>                                 write_mc at 38 {
>                                         id = <0x0>;
>                                         reg = <0x38 0x8>;
>                                         unit = "MiB";
>                                         scale = "1.2207e-4";

As I mentioned elsewhere, I'm not keen on these bindings.

1.2204e-4 seems to just be 1/8192.  MiB is just a number also.  I think
you are combining these to give a final scale number which in this case
(I think is just 128).

  1.2204e-4 * 2**20 = 127.96821504

I'd prefer you just put that in the device tree.

Mikey