[Skiboot] [PATCH 6/7] hmi: Only raise a catchall HMI if no other components have
Russell Currey
ruscur at russell.cc
Tue Mar 15 21:26:26 AEDT 2016
On Tue, 2016-03-15 at 18:33 +1100, Russell Currey wrote:
<snip>
> static void wait_for_subcore_threads(void)
> @@ -697,8 +696,7 @@ int handle_hmi_exception(uint64_t hmer, struct
> OpalHMIEvent *hmi_evt)
> recover = 0;
Just realised this line ^ is now pointless since that variable doesn't get
touched in decode_malfunction. I'll remove that in the next revision, will
leave this one up to get comments.
>
> if (hmi_evt) {
> - recover = decode_malfunction(hmi_evt);
> - queue_hmi_event(hmi_evt, recover);
> + decode_malfunction(hmi_evt);
> }
The braces here are redundant too.
> }
>
More information about the Skiboot
mailing list