[Skiboot] [PATCH v2] bt: use the maximum retry count returned by the BMC

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Mar 15 16:09:06 AEDT 2016

On 03/15/2016 10:15 AM, Vasant Hegde wrote:
> On 03/14/2016 04:07 PM, Cédric Le Goater wrote:
>> OpenPower systems using a AMI firmware on the BMC have a BT device
>> configured with a capability of '1' maximum retry. The following code
>> is equivalent to what skiboot currently supports but it will now also
>> handle setups of other BT devices, like in qemu or OpenBMC.
>> Signed-off-by: Cédric Le Goater <clg at fr.ibm.com>
> Patch looks good.
> Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>


Looks like we are not making use of input_buf_len and output_buf_len 
capabilities. We will be in trouble if we endup getting capabilities lesser than 
IPMI_MAX_REQ_SIZE. May be its better to check that as well..


More information about the Skiboot mailing list