[Skiboot] [PATCH] libflash/libffs: Reporting seeing all 0xFF bytes during init.

Stewart Smith stewart at linux.vnet.ibm.com
Fri Mar 11 15:49:01 AEDT 2016

Cyril Bur <cyril.bur at au1.ibm.com> writes:
> When flash controllers get deconfigured or yanked out from under these
> tools flash accesses tend to just return all 0xFF bytes.
> libffs is usually the first thing to do reads and will fail parsing its
> partition structures. This patch adds reporting when it fails to parse
> because it got all 0xFF bytes.
> The idea is that this will help debugging by splitting the possible reasons
> for a failed init into 1) flash controller issue or reading erased flash 2)
> flash corruption or not valid reading partition data. These two cases are
> nice to be able to separate as early as possible as they usually mean two
> quite different type of bugs.
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> ---
>  libflash/libffs.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

Thanks, merged to master as of 6da1679

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list