[Skiboot] [PATCH] ipmi-sel: Fix memory leak in error path

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Mar 10 03:26:16 AEDT 2016


Commit a5299ba2 dropped non-severe event from logging to BMC, but I forgot
to releaes the error log structure.

Fixes: a5299ba2 (IPMI: Only log events that needs attention)
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hw/ipmi/ipmi-sel.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
index 4610829..a563f71 100644
--- a/hw/ipmi/ipmi-sel.c
+++ b/hw/ipmi/ipmi-sel.c
@@ -404,6 +404,7 @@ int ipmi_elog_commit(struct errorlog *elog_buf)
 	if (elog_buf->event_severity < OPAL_PREDICTIVE_ERR_FAULT_RECTIFY_REBOOT ||
 	    elog_buf->elog_origin != ORG_SAPPHIRE) {
 		prlog(PR_INFO, "dropping non severe PEL event\n");
+		opal_elog_complete(elog_buf, true);
 		return 0;
 	}
 



More information about the Skiboot mailing list