[Skiboot] [PATCH] hw/ipmi: fix event data 1 for System Firmware Progress sensor

Stewart Smith stewart at linux.vnet.ibm.com
Mon Mar 7 18:19:52 AEDT 2016


Cédric Le Goater <clg at fr.ibm.com> writes:
> The IPMI Specs document (29.7 Event Data Field Formats) describes the
> Event Data 1 field for discrete sensor as follow :
>
> 	[7:6] -	00b = unspecified byte 2
> 		01b = previous state and/or severity in byte 2
> 		10b = OEM code in byte 2
> 		11b = sensor-specific event extension code in byte 2
> 	[5:4] -	00b = unspecified byte 3
> 		01b = reserved
> 		10b = OEM code in byte 3
> 		11b = sensor-specific event extension code in byte 3
> 	[3:0] - Offset from Event/Reading Code for discrete event state
>
> The "System Firmware Progress" offset in the "System Firmware
> Progress" Sensor being 0x02, we should be using 0xc2 in the event data
> 1 field.
>
> Signed-off-by: Cédric Le Goater <clg at fr.ibm.com>
> ---
>  Tested on a palmetto and under qemu
>
>  hw/ipmi/ipmi-sensor.c |    1 +
>  1 file changed, 1 insertion(+)

Well spotted! Merged to master as of
67212eb3ca9fed121432b814b5e58fb8d2cfebae

Should this also go to stable?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list