[Skiboot] [PATCH 2/4] init: Update comments for branch null catcher

Michael Neuling mikey at neuling.org
Mon Mar 7 13:27:32 AEDT 2016


Make note that this will be broken for little endian.

Signed-off-by: Michael Neuling <mikey at neuling.org>
---
 core/init.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/core/init.c b/core/init.c
index 54a5735..1d2f6e0 100644
--- a/core/init.c
+++ b/core/init.c
@@ -533,6 +533,12 @@ static void branch_null(void)
 static void setup_branch_null_catcher(void)
 {
 	void (*bn)(void) = branch_null;
+
+	/*
+	 * FIXME: This copies the function descriptor (16 bytes) for
+	 * ABI v1 (ie. big endian).  This will be broken if we ever
+	 * move to ABI v2 (ie little endian)
+	 */
 	memcpy(0, bn, 16);
 }
 
-- 
2.5.0



More information about the Skiboot mailing list