[Skiboot] [PATCH V3 1/6] opal/errorlog : Generalize the errorlog write path to host

[Stewart Smith]

Mukesh Ojha <mukesh02 at linux.vnet.ibm.com> writes:
> Movement of opal errorlog generic functions from fsp-elog-write.c to new
> file core/elog-host.c . Function declarations are kept in errorlog.h, which
> was there in fsp-elog.h earlier and fsp specific header files are kept in
> fsp-elog.h .
>
> Implementation of generic init routine for errorlog writing to host will
> be initialised independent of the platform on which it is going to run. It
> also involves a common memory buffer which will be used to copy the logs
> from opal to host buffer.

I dislike the use of 'host' around here, as it doesn't add any clarity.

I'd be happy to have the platform independent code in core/errorlog.c 

> Signed-off-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>
>
> ---
> Changes in V3:
>  -Change of letter case in the description.
>
> Changes in V2:
>  -No Changes.
>
>  core/Makefile.inc          |   1 +
>  core/elog-host.c           | 193 +++++++++++++++++++++++++++++++++++++++++++++
>  hw/fsp/fsp-elog-write.c    | 173 +---------------------------------------
>  include/errorlog.h         |   5 +-
>  platforms/ibm-fsp/common.c |   6 +-
>  5 files changed, 206 insertions(+), 172 deletions(-)
>  create mode 100644 core/elog-host.c
>
> diff --git a/core/Makefile.inc b/core/Makefile.inc
> index 5af0d7c..4a623de 100644
> --- a/core/Makefile.inc
> +++ b/core/Makefile.inc
> @@ -8,6 +8,7 @@ CORE_OBJS += device.o exceptions.o trace.o affinity.o vpd.o
>  CORE_OBJS += hostservices.o platform.o nvram.o nvram-format.o hmi.o
>  CORE_OBJS += console-log.o ipmi.o time-utils.o pel.o pool.o errorlog.o
>  CORE_OBJS += timer.o i2c.o rtc.o flash.o sensor.o ipmi-opal.o
> +CORE_OBJS += elog-host.o
>  
>  ifeq ($(SKIBOOT_GCOV),1)
>  CORE_OBJS += gcov-profiling.o
> diff --git a/core/elog-host.c b/core/elog-host.c
> new file mode 100644
> index 0000000..5b4ccb5
> --- /dev/null
> +++ b/core/elog-host.c
> @@ -0,0 +1,193 @@
> +/* Copyright 2016 IBM Corp.

Unless this is entirely new code from this year, should be 2013-2016
just like where it came from.


-- 
Stewart Smith
OPAL Architect, IBM.