[Skiboot] [PATCH 2/2] slw: FWTS annotation suggestion for SLWRegisterDump

Stewart Smith stewart at linux.vnet.ibm.com
Thu Jun 30 13:48:06 AEST 2016


Suggested-by: Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hw/slw.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/slw.c b/hw/slw.c
index 1fc90dbb0966..3ebe01a2b3cb 100644
--- a/hw/slw.c
+++ b/hw/slw.c
@@ -1192,10 +1192,10 @@ static void slw_dump_timer_ffdc(void)
 
 	/**
 	 * @fwts-label SLWRegisterDump
-	 * @fwts-advice An error condition occured where the SLeep/Winkle
-	 * engine had to dump out the register state for assisitng in
-	 * debugging. This means that power saving states are likely
-	 * not functioning correctly.
+	 * @fwts-advice An error condition occured in sleep/winkle
+	 * engines timer state machine. Dumping debug information to
+	 * root-cause. OPAL/skiboot may be stuck on some operation that
+	 * requires SLW timer state machine (e.g. core powersaving)
 	 */
 	prlog(PR_ERR, "SLW: Register state:\n");
 
-- 
2.1.4



More information about the Skiboot mailing list