[Skiboot] [PATCH] fsp/op-panel: Fix out of bounds array access and #define display dimensions

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Wed Jun 29 15:28:59 AEST 2016

On 06/28/2016 09:50 AM, Suraj Jitindar Singh wrote:
> In the function __opal_write_oppanel() coverity complains about an out
> of bounds array access. While the pointer is never actually dereferenced,
> this isn't immediately obvious from the code. Additionally the number and
> length of the lines on the operator panel display are hard coded into
> the function. While we are here we might as well move these into a #define
> statement.
> Rework the code in __opal_write_oppanel() where the message is copied into
> the buffer so that coverity won't complain about an out of bounds array
> access and so that it is line number and length agnostic (now relying on
> the #defined values).
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh at gmail.com>

Looks good.

Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>


More information about the Skiboot mailing list