[Skiboot] [PATCH] external: Fix ARM build failure with parallel make

Stewart Smith stewart at linux.vnet.ibm.com
Tue Jun 28 13:44:41 AEST 2016


Patrick Williams <patrick at stwcx.xyz> writes:
> On Mon, Jun 27, 2016 at 04:22:43PM +1000, Stewart Smith wrote:
>> Brad Bishop <bradleyb at fuzziesquirrel.com> writes:
>> > Arch headers need to be linked in before compiling.
>> >
>> > Signed-off-by: Brad Bishop <bradleyb at fuzziesquirrel.com>
>> > ---
>> >  external/common/rules.mk | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> makes sense, merged to master as of 5660d30.
>> 
>> Did you need this in stable as well?
>> 
> Stewart,
>
> We are currently pointing at 5.2.2 for pflash in openbmc.  I don't think
> you have merged any meaningful fixes past this into the 5.2.x branch, so
> we can just keep it as a patch.  Only if you think there is value in us
> moving up to a later 5.2.x at some point would we appreciate this in
> stable.  I suspect this small makefile patch will apply cleanly for us
> even if we point at a new 5.2.x.

In 5.2.x, nothing meaningful for pflash at least. I'll cherry pick this
commit back anyway, if only for completeness.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list