[Skiboot] [PATCH 00/14] FWTS Annotations for prlog(PR_ERR

[Vaidyanathan Srinivasan]

* Stewart Smith <stewart at linux.vnet.ibm.com> [2016-06-27 16:23:54]:

> Stewart Smith <stewart at linux.vnet.ibm.com> writes:
> > This patchset adds FWTS annotations for (most of) the prlog(PR_ERR) calls
> > in skiboot. This enables the FirmWare Test Suite (FWTS) to examine the OPAL
> > log for errors that may have occurred during boot.
> >
> > This patch set does *not* address every perror() call (and, in fact, converts
> > some prerror calls into prlog calls so that generate-fwts-olog would pick
> > them up). It also does *not* go through each macro that wraps prlog() in its
> > own special way. Both of these tasks are left for future patch sets.
> >
> > Jeremy Kerr (1):
> >   external/fwts: fix regex generation for %p format
> >
> > Stewart Smith (13):
> >   ibm-fsp/lxvpd: convert to straight prlog() calls with pr_fmt
> >   astbmc/common: add FWTS annotation
> >   ipmi-sel: Add FWTS annotations for some errors
> >   fsp-epow: add FWTS annotation
> >   fsp-sensor: add FWTS annotation for already existing sensor node
> >   i2c: Add FWTS annotations for I2c Errors
> >   fsp-elog: add FWTS annotations for several errors
> >   slw: add FWTS annotations for errors
> >   fsp-leds: Add FWTS annotations for some errors
> >   fsp-surveillance: add FWTS annotation on failing to reply to heartbeat
> >   occ: add FWTS annotations for OCC errors
> >   core/opal.c: Add FWTS annotations for pollers and missing
> >     OPAL_CHECK_TOKEN
> >   hdata/memory.c: add FWTS annotation for invalid timebase size
> >
> >  core/i2c.c                       |  13 +++++
> >  core/opal.c                      |  32 ++++++++++-
> >  external/fwts/generate-fwts-olog |   2 +-
> >  hdata/memory.c                   |   6 +++
> >  hw/fsp/fsp-elog-read.c           |  23 ++++++++
> >  hw/fsp/fsp-elog-write.c          |   6 +++
> >  hw/fsp/fsp-epow.c                |  10 ++++
> >  hw/fsp/fsp-leds.c                |  34 ++++++++++++
> >  hw/fsp/fsp-sensor.c              |   7 +++
> >  hw/fsp/fsp-surveillance.c        |   9 +++-
> >  hw/ipmi/ipmi-sel.c               |  10 ++++
> >  hw/occ.c                         | 112 +++++++++++++++++++++++++++++++++------
> >  hw/slw.c                         |  13 +++++
> >  platforms/astbmc/common.c        |   5 ++
> >  platforms/ibm-fsp/lxvpd.c        |  33 +++++-------
> >  15 files changed, 277 insertions(+), 38 deletions(-)
> 
> merged to master as of c4d48a3 (since it's just FWTS annotations, not
> too worried about merging quickly).
> 
> Any changes can come in as patches.

:) I will sent further tweaks as patches.

--Vaidy