[Skiboot] [PATCH v6 12/16] hw/phb3: Support PHB slot

Gavin Shan gwshan at linux.vnet.ibm.com
Mon Jun 27 16:24:02 AEST 2016


On Mon, Jun 27, 2016 at 11:06:59AM +1000, Benjamin Herrenschmidt wrote:
>On Mon, 2016-06-27 at 09:59 +1000, Gavin Shan wrote:
>> Ben, thanks for spotting it out. I agree it's unnecessary and I'll
>> remove this with follow-up patches. This logic (hot reset after
>> fundamental reset) was introduced for PCI slots on Firenze platform,
>> meaning a hot reset is issued after power state is changed via I2C
>> bus. This change was introduced to be compatible with that.
>
>That shouldn't be necessary since the power state change should have
>resulted in a PERST.. unless we are missing something that is.
>

Yeah, thanks, Ben. I will have patches to drop it as well, but it's
something for next week :)

Thanks,
Gavin

>Cheers,
>Ben.
>



More information about the Skiboot mailing list