[Skiboot] [PATCH 10/14] fsp-surveillance: add FWTS annotation on failing to reply to heartbeat
Stewart Smith
stewart at linux.vnet.ibm.com
Mon Jun 27 15:32:08 AEST 2016
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
hw/fsp/fsp-surveillance.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/fsp/fsp-surveillance.c b/hw/fsp/fsp-surveillance.c
index 24acead9eeb5..d3e5c450c3b7 100644
--- a/hw/fsp/fsp-surveillance.c
+++ b/hw/fsp/fsp-surveillance.c
@@ -58,9 +58,16 @@ static void fsp_surv_ack(struct fsp_msg *msg)
lock(&surv_lock);
fsp_surv_ack_pending = false;
unlock(&surv_lock);
- } else
+ } else {
+ /**
+ * @fwts-label FSPHeartbeatAckError
+ * @fwts-advice Error in acknowledging heartbeat to FSP.
+ * This could mean the FSP has gone away or it may mean
+ * the FSP may kill us for missing too many heartbeats.
+ */
prlog(PR_ERR,
"SURV: Heartbeat Acknowledgment error from FSP\n");
+ }
fsp_freemsg(msg);
}
--
2.1.4
More information about the Skiboot
mailing list