[Skiboot] [PATCH 02/14] astbmc/common: add FWTS annotation

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jun 27 15:32:00 AEST 2016


Just one annotation here, pretty rare situation I think... but
best to bail on this one, as this certainly isn't something we
want in production.

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 platforms/astbmc/common.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c
index 1ed7d42dd836..d38de3ba48b6 100644
--- a/platforms/astbmc/common.c
+++ b/platforms/astbmc/common.c
@@ -78,6 +78,11 @@ static void astbmc_ipmi_setenables(void)
 
         msg = ipmi_mkmsg_simple(IPMI_SET_ENABLES, &data, sizeof(data));
         if (!msg) {
+		/**
+		 * @fwts-label ASTBMCFailedSetEnables
+		 * @fwts-advice AST BMC is likely to be non-functional
+		 * when accessed from host.
+		 */
                 prlog(PR_ERR, "ASTBMC: failed to set enables\n");
                 return;
         }
-- 
2.1.4



More information about the Skiboot mailing list