[Skiboot] [PATCH 5/5] fsp-elog-write: display error code from FSP on error writing error log

Joel Stanley joel at jms.id.au
Fri Jun 24 12:21:19 AEST 2016


On Fri, Jun 24, 2016 at 11:06 AM, Stewart Smith
<stewart at linux.vnet.ibm.com> wrote:
> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
> ---
>  hw/fsp/fsp-elog-write.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/fsp/fsp-elog-write.c b/hw/fsp/fsp-elog-write.c
> index cf915a2cb1d7..d4b5237510bc 100644
> --- a/hw/fsp/fsp-elog-write.c
> +++ b/hw/fsp/fsp-elog-write.c
> @@ -97,7 +97,7 @@ static void opal_fsp_write_complete(struct fsp_msg *read_msg)
>         default:
>                 if (elog_write_retries++ >= MAX_RETRIES) {
>                         remove_elog_head_entry();
> -                       prerror("ELOG: Error in writing to FSP!\n");
> +                       prerror("ELOG: Error in writing to FSP (%x)!\n", val);

Will this be clear that it's a hex value? Should we do 0x%x? Or %08x? Or both?

>                 }
>                 break;
>         }
> --
> 2.1.4
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot


More information about the Skiboot mailing list