[Skiboot] [PATCH 4/5] fsp-sensor: add FWTS annotation for already existing sensor node

Stewart Smith stewart at linux.vnet.ibm.com
Fri Jun 24 11:36:45 AEST 2016


Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hw/fsp/fsp-sensor.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/hw/fsp/fsp-sensor.c b/hw/fsp/fsp-sensor.c
index 78d95f91cd22..51ee8724c3cc 100644
--- a/hw/fsp/fsp-sensor.c
+++ b/hw/fsp/fsp-sensor.c
@@ -604,6 +604,13 @@ static struct dt_node *sensor_get_node(struct dt_node *sensors,
 			 frc_names[header->frc]);
 		dt_add_property_string(node, "compatible", name);
 	} else {
+		/**
+		 * @fwts-label OPALSensorNodeExists
+		 * @fwts-advice OPAL had trouble creating the sensor
+		 * nodes in the device tree as there was already one there.
+		 * This indicates either the device tree from Hostboot
+		 * already filled in sensors or an OPAL bug.
+		 */
 		prlog(PR_ERR, "SENSOR: node %s exists\n", name);
 	}
 	return node;
-- 
2.1.4



More information about the Skiboot mailing list