[Skiboot] [PATCH] hw/lpc.c: Fix uninitialized pointer read in error path

Vipin K Parashar vipin at linux.vnet.ibm.com
Tue Jun 21 17:23:29 AEST 2016


Thanks Stewart!!

Reviewed-by: Vipin K Parashar <vipin at linux.vnet.ibm.com>

On Tuesday 21 June 2016 07:23 AM, Stewart Smith wrote:
> Found by static analysis
>
> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
> ---
>   hw/lpc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/lpc.c b/hw/lpc.c
> index d2a72f1d024f..388b4e93732c 100644
> --- a/hw/lpc.c
> +++ b/hw/lpc.c
> @@ -618,7 +618,7 @@ static void lpc_dispatch_reset(struct proc_chip *chip)
>   static void lpc_dispatch_err_irqs(struct proc_chip *chip, uint32_t irqs)
>   {
>   	int rc;
> -	const char *sync_err;
> +	const char *sync_err = "Unknown LPC error";
>   	uint32_t err_addr;
>   
>   	/* Write back to clear error interrupts, we clear SerIRQ later



More information about the Skiboot mailing list