[Skiboot] [PATCH] nvlink: Enable NPU device BAR before triggering freeze
Stewart Smith
stewart at linux.vnet.ibm.com
Tue Jun 21 15:58:13 AEST 2016
Russell Currey <ruscur at russell.cc> writes:
> NPU freeze injection works by performing an invalid MMIO read on the NPU
> device BAR. If the BAR isn't enabled, which is the case when the
> appropriate driver isn't loaded, this checkstops the machine.
>
> Work around this by making sure the BAR is enabled before performing the
> read. The idea of an error inject doing anything other than an error
> inject isn't great, but it's better than unintentionally crashing your
> machine.
>
> Also, fix the comment incorrectly stating the operation was a write
> instead of a read.
>
> Signed-off-by: Russell Currey <ruscur at russell.cc>
> ---
> hw/npu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Looks good, merged to master as of 0f23e5b
--
Stewart Smith
OPAL Architect, IBM.
More information about the Skiboot
mailing list