[Skiboot] [PATCH 2/4] fwts: add annotations for core flash/nvram functionality
Stewart Smith
stewart at linux.vnet.ibm.com
Mon Jun 20 18:28:18 AEST 2016
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
core/flash.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/core/flash.c b/core/flash.c
index 734e0fab1d36..6c0d2ffea9ab 100644
--- a/core/flash.c
+++ b/core/flash.c
@@ -277,12 +277,24 @@ int flash_register(struct blocklevel_device *bl, bool is_system_flash)
if (!flash) {
unlock(&flash_lock);
+ /**
+ * @fwts-label NoFlashSlots
+ * @fwts-advice System has more flash chips than skiboot
+ * was configured to know about. Your system will not be
+ * able to access some of the flash it has.
+ */
prlog(PR_ERR, "FLASH: No flash slots available\n");
return OPAL_RESOURCE;
}
rc = ffs_init(0, flash->size, bl, &ffs, 0);
if (rc) {
+ /**
+ * @fwts-label NoFFS
+ * @fwts-advice System flash isn't formatted as expected.
+ * This could mean several OPAL utilities do not function
+ * as expected. e.g. gard, pflash.
+ */
prlog(PR_WARNING, "FLASH: No ffs info; "
"using raw device only\n");
ffs = NULL;
--
2.1.4
More information about the Skiboot
mailing list