[Skiboot] [PATCH v12 02/23] core/fdt: Improve debugging functionality

Gavin Shan gwshan at linux.vnet.ibm.com
Fri Jun 10 17:05:11 AEST 2016

On Fri, Jun 10, 2016 at 03:25:21PM +1000, Andrew Donnellan wrote:
>On 10/06/16 15:03, Gavin Shan wrote:
>>  #undef DEBUG_FDT
>>+#ifdef DEBUG_FDT
>>+#define FDT_DBG(fmt, a...)	prlog(PR_DEBUG, "FDT: " fmt, ##a)
>>+#define FDT_DBG(fmt, a...)
>I don't see why it should require DEBUG_FDT, but I'm not particularly fussed
>by this.

Yeah, there is no strong reason to have DEBUG_FDT here as the message severity
is PR_DEBUG. There is a stub for dump_fdt() as below, which neededs this. Thanks
for the review, Andrew.

#ifdef DEBUG_FDT
static void dump_fdt(void *fdt)
static inline void dump_fdt(void *fdt __unused) { }


>Andrew Donnellan              OzLabs, ADL Canberra
>andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list