[Skiboot] [PATCH] OPAL:PCI should throw error on platform PCI devices not being detected

Mamatha Inamdar mamatha4 at linux.vnet.ibm.com
Thu Jun 9 16:12:34 AEST 2016



>>>> diff --git a/include/errorlog.h b/include/errorlog.h
>>>> index b8fca7d..5b754f7 100644
>>>> --- a/include/errorlog.h
>>>> +++ b/include/errorlog.h
>>>> @@ -280,7 +280,8 @@ enum opal_reasoncode {
>>>>       OPAL_RC_PCI_INIT_SLOT   = OPAL_PC | 0x10,
>>>>       OPAL_RC_PCI_ADD_SLOT    = OPAL_PC | 0x11,
>>>>       OPAL_RC_PCI_SCAN        = OPAL_PC | 0x12,
>>>> -    OPAL_RC_PCI_RESET_PHB   = OPAL_PC | 0x10,
>>>> +    OPAL_RC_PCI_RESET_PHB   = OPAL_PC | 0x13,
>>>> +    OPAL_RC_PCI_SLOT    = OPAL_PC | 0x14,
>>>
>>> Can't we use 'OPAL_RC_PCI_INIT_SLOT' here?
>>
>> In this patch We are not initializing the SLOT to use  above reason 
>> code,
>> We are checking the devices are detected or not in the available slot.
>>
>
> Then, we could name it as OPAL_RC_PCI_DETECT_SLOT.
>
> -Mukesh

yeah, I am planing to name it as OPAL_RC_PCI_DETECT_DEVICE

>
>>>
>>> Cheers,
>>> -Mukesh
>>>
>>>>   /* ATTN */
>>>>       OPAL_RC_ATTN        = OPAL_AT | 0x10,
>>>>   /* MEM_ERR */
>>>>
>>>> _______________________________________________
>>>> Skiboot mailing list
>>>> Skiboot at lists.ozlabs.org
>>>> https://lists.ozlabs.org/listinfo/skiboot
>>>
>>
>



More information about the Skiboot mailing list