[Skiboot] [PATCH v11 17/23] platforms/ibm-fsp: Support PCI slot

Stewart Smith stewart at linux.vnet.ibm.com
Wed Jun 8 15:30:44 AEST 2016

Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> On Tue, 2016-05-24 at 13:58 +1000, Alistair Popple wrote:
>> Hi Gavin,
>> I haven't looked at the code here in depth yet, but I have made a few comments 
>> below. It looks like there is still a reasonable amount of non-platform 
>> specific code under the FSP platform which personally I think would be much 
>> better in the core pci code. This way other platforms could just implement 
>> slot power on/off and get all the functionality required for hotplug.
> That may be true but I wouldn't gate the merge on this, it's been long
> enough... we can move things out later if we need to.


I'm okay with taking the hotplug/slot enablement work and have a
separate series clean up state machine cranking.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list