[Skiboot] [PATCH v11 13/23] core/pci: Support PCI slot

Stewart Smith stewart at linux.vnet.ibm.com
Wed Jun 8 14:58:13 AEST 2016

Gavin Shan <gwshan at linux.vnet.ibm.com> writes:
> Every PCIE bridge port or PHB is expected to be bound with PCI slot
> , to which various PCI slot's functionalities are attached (e.g. power,
> link, reset). This supports PCI slot:
>    * PCI slot is reprsented by "struct pci_slot".
>    * "struct pci_slot_ops" represents the functions supported on the
>      PCI slot. It's initialized by PCI slot core at the beginning and
>      allowed to be overrided by platform partially or completely.
>    * On PCI hot plugging event, the PCI devices behind the slot are
>      enumarated. Device sub-tree is populated and sent to OS by OPAL
>      message.
>    * On PCI hot unplugging event, the PCI devices behind the slot are
>      destroyed. Device sub-tree is removed and the slot is powered off.
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>

Am okay to take this as is, Although I still think we could improve how
PCI works with the OPAL/Linux interface using proper async calls
everywhere (yes, this is ABI change, so, realistically, POWER9 is where
we can do that). I'd prefer we crank the state machine using the OPAL
async infrastructure (perhaps extending it to provide hints as to when
to come back and check things).

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list