[Skiboot] [PATCH v3 5/6] slw: Move IDLE_TB_STOP and IDLE_LOSE_FULL_CONTEXT to opal-api.h

Shreyas B Prabhu shreyas at linux.vnet.ibm.com
Tue Jun 7 21:47:09 AEST 2016



On 06/06/2016 11:56 AM, Michael Neuling wrote:
> On Thu, 2016-06-02 at 14:20 +0530, Shreyas B. Prabhu wrote:
>> Move IDLE_TB_STOP and IDLE_LOSE_FULL_CONTEXT to opal-api.h since these
>> flags will be used by the kernel.
>> This patch does not change any functionality.
> 
> These flags are exported via the device tree, so why don't we export
> all of these flag definitions?  Why do we export stuff in the flags
> that we don't have usable definitions for?
> 

While the kernel does not use all the flags, I think it makes sense to
retain them since these flags comprehensively describe a given idle
state. As you suggested I can move all the flag definitions to opal-api.h .

Thanks,
Shreyas



More information about the Skiboot mailing list