[Skiboot] [PATCH v3 6/6] slw: Allow adding idle states to power-mgt node in mambo

[Michael Neuling]

On Thu, 2016-06-02 at 14:20 +0530, Shreyas B. Prabhu wrote:


> This patch removes the check which prevents adding any idle state to
> "power-mgt" node in mambo.
> 
> Power8 exposes 3 idle states- nap, fast-sleep and deep-winkle.
> While fast-sleep depends on SCOMs and deep-winkle depends on SCOMs/SLW,
> nap has no such dependencies and it can be enabled in mambo. Current code
> checks for "fast-sleep" in hostboot provided
> "ibm,enabled-idle-states" dt node for adding fast-sleep and checks
> for presence of SLW for adding winkle to "power-mgt". Hence with this
> change only nap will be added to "power-mgt" node in mambo on Power8.
> 
> On Power9, this patch enables all idle states which don't need SLW.
> 
> Signed-off-by: Shreyas B. Prabhu <shreyas at linux.vnet.ibm.com>
> 

This looks good.  One minor comment below, if you address that then:

Acked-by: Michael Neuling <mikey at neuling.org>


> diff --git a/include/chip.h b/include/chip.h
> index 340941986371..ea42b56b9419 100644
> --- a/include/chip.h
> +++ b/include/chip.h
> @@ -118,7 +118,6 @@ enum proc_chip_quirks {
>  	QUIRK_NO_F000F		= 0x00000004,
>  	QUIRK_NO_PBA		= 0x00000008,
>  	QUIRK_NO_OCC_IRQ       	= 0x00000010,
> -	QUIRK_DISABLE_NAP	= 0x00000020,

Please repack these.

>  	QUIRK_SIMICS		= 0x00000040,
>  } proc_chip_quirks;
>