[Skiboot] [PATCH v11 07/23] core/fdt: Introduce opal_get_device_tree()

[Andrew Donnellan]

On 20/05/16 16:32, Gavin Shan wrote:
> This introduces OPAL API opal_get_device_tree() to get the device
> sub-tree. It's going to be used in PCI hot add path.
>
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>

I don't see anything obviously wrong here - as far as I can tell it 
covers all the error paths.

One minor comment below.

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

> diff --git a/doc/opal-api/opal-get-device-tree-118.txt b/doc/opal-api/opal-get-device-tree-118.txt
> new file mode 100644
> index 0000000..cacbd96
> --- /dev/null
> +++ b/doc/opal-api/opal-get-device-tree-118.txt
> @@ -0,0 +1,23 @@
> +OPAL_GET_DEVICE_TREE
> +--------------------
> +
> +Get device sub-tree
> +
> +Parameters:
> +	uint32_t phandle: root device node phandle of the device sub-tree
> +	uint64_t buf: FDT blob buffer or NULL
> +	uint64_t len: length of the FDT blob buffer
> +
> +Calling:
> +
> +Retrieve device sub-tree. The root node's phandle is identified by @phandle.
> +The typical use is notify kernel a change in hardware.

"notify the kernel of a change in hardware"

Perhaps:

"The typical use is for the kernel to update its device tree following a 
change in hardware (e.g. PCI hotplug)."

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited