[Skiboot] [PATCH v2 3/5] slw: Add Power9 idle states to power-mgt dt node

[Shreyas B Prabhu]

On 06/01/2016 11:55 AM, Michael Neuling wrote:
> 
>> @@ -652,18 +748,29 @@ void add_cpu_idle_state_properties(void)
>>  			residency_ns_buf, num_supported_idle_states * sizeof(u32));
>>  	dt_add_property(power_mgt, "ibm,cpu-idle-state-flags", flags_buf,
>>  			num_supported_idle_states * sizeof(u32));
>> -	dt_add_property(power_mgt, "ibm,cpu-idle-state-pmicr", pmicr_buf,
>> -			num_supported_idle_states * sizeof(u64));
>> -	dt_add_property(power_mgt, "ibm,cpu-idle-state-pmicr-mask",
>> -			pmicr_mask_buf, num_supported_idle_states * sizeof(u64));
>>  
>> +	if (has_stop_inst) {
>> +		dt_add_property(power_mgt, "ibm,cpu-idle-state-psscr",
>> +				pm_ctrl_reg_val_buf,
>> +				num_supported_idle_states * sizeof(u64));
>> +		dt_add_property(power_mgt, "ibm,cpu-idle-state-psscr-mask",
>> +				pm_ctrl_reg_mask_buf,
>> +				num_supported_idle_states * sizeof(u64));
>> +	} else {
>> +		dt_add_property(power_mgt, "ibm,cpu-idle-state-pmicr",
>> +				pm_ctrl_reg_val_buf,
>> +				num_supported_idle_states * sizeof(u64));
>> +		dt_add_property(power_mgt, "ibm,cpu-idle-state-pmicr-mask",
>> +				pm_ctrl_reg_mask_buf,
>> +				num_supported_idle_states * sizeof(u64));
>> +	}
> 
> As mpe mentioned in the associated linux thread... Can you add these
> properties to: 
> doc/device-tree/ibm,opal/power-mgt.txt
> 

I've added the documentation in V3.

Thanks,
Shreyas