[Skiboot] [PATCH] core/flash: Fix passing pointer instead of value

Stewart Smith stewart at linux.vnet.ibm.com
Thu Jul 28 14:49:42 AEST 2016


Cyril Bur <cyril.bur at au1.ibm.com> writes:
> flash_find_subpartition() accepts a pointer to a boolean variable
> indicating ecc for a region of flash and passes the pointer directly
> to flash_read_corrected() which actually only wants the value. This
> has always worked probably because there has always been ECC on
> sub partitions.
>
> How there aren't any warnings triggered by this condition escapes me.
>
> Fixes: 6c26bc7 ("libflash: move ffs_flash_read into libflash")
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>

Thanks, merged to master 81a538a678edf666568ca4adffe074b3dbce6dc3

Also should go to stable?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list