[Skiboot] [PATCH V2 2/2] platforms/ibm-fsp: Use power_ctl bit when determining slot reset method

Suraj Jitindar Singh sjitindarsingh at gmail.com
Wed Jul 27 14:27:10 AEST 2016



On 25/07/16 12:11, Stewart Smith wrote:
> Suraj Jitindar Singh <sjitindarsingh at gmail.com> writes:
>> Previously the power_clt bit provided by the VPD was unused, now that we
>> are correctly assigning it we can use it when determining the slot reset
>> method.
>>
>> The power_ctl bit is used to represent if power management is available.
>> If power_ctl is set to true, then the I2C based external power management
>> functionality will be populated on the PCI slot. Otherwise we will try to
>> use the inband PERST as the fundamental reset, as before.
>>
>> While we are here we introduce a helper function to isolate the logic
>> initialisation for the I2C based external power management, to improve
>> readibility.
>>
>> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh at gmail.com>
>> Acked-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> no longer applies cleanly to master, looks relatively trivial to fix
> though. able to resend?
>
Thanks, will update and resend



More information about the Skiboot mailing list