[Skiboot] [PATCH V4 0/6] opal/errorlog : Generalizes error log read/write routines and adds write to host support for BMC systems

Mukesh Ojha mukesh02 at linux.vnet.ibm.com
Tue Jul 26 15:45:32 AEST 2016

Currently, in the process of committing an error to FSP from OPAL, log info
is first internally converted to PEL format and then pushed to the FSP.
All the errors reported by OPAL are logged in FSP, if for some reason(say
FSP is down) OPAL is not able to log its error with in a particular time,
Then it sends the log to the host directly. So, All the errors logs
(FSP + OPAL) are pushed up to host platform by the FSP.

This patchset improves current error log infrastructure by splitting
existing FSP specific error log read/write routines into common and
hardware(FSP) specific routines. This would add error log writing to
host support for BMC based platforms.

It involves movement of some functions from FSP specific fsp-elog-write.c
and fsp-elog-read.c files to core/errorlog.c . Introduction of platform
hooks for elog info, ack, read and resend pending logs.

Patch 1 does some modification related to alignment, typo mistakes and
upper-lower case issues etc.

Patch 2 does function movement related to write to host path.

Patch 3 changes function name
        fsp_elog_write_set_head_state => opal_elog_write_set_head_state

Patch 4 does movement of opal registration of callbacks from fsp-elog-read.c
to generic core/errorlog.c . Detail description is there in the patch.

Patch 5 Introduces the reference count field in error log structure and
addition of put_elog, get_log routine, which will be used in later patch.

Patch 6 adds the support of error log write to the host for BMC systems
using generic framework.

Mukesh Ojha (6):
  opal/errorlog : Modification as per coding guidelines to make the code
    more legible
  opal/errorlog : Generalizes the error log write path to host
  opal/errorlog : Gives function'fsp_elog_write_set_head_state' a more
    meaningful name
  opal/errorlog : Generalizes the error log read path
  Introduces get and put elog routine and reference count field in elog
  opal/errorlog : Enables error log write to host on BMC systems

 core/errorlog.c             | 284 ++++++++++++++++++++++++++++++++++++++++----
 hw/fsp/fsp-elog-read.c      | 236 ++++++++++++++----------------------
 hw/fsp/fsp-elog-write.c     | 265 +++++++----------------------------------
 hw/ipmi/ipmi-sel.c          | 105 ++++++++--------
 include/errorlog.h          |  23 +++-
 include/fsp-elog.h          |  38 ++----
 include/platform.h          |  23 ++++
 platforms/astbmc/common.c   |   6 +-
 platforms/ibm-fsp/apollo.c  |   7 +-
 platforms/ibm-fsp/common.c  |   4 +
 platforms/ibm-fsp/firenze.c |   7 +-
 11 files changed, 522 insertions(+), 476 deletions(-)


More information about the Skiboot mailing list