[Skiboot] [PATCH] include/errorlog.h : Renames SRC component's macro name
Stewart Smith
stewart at linux.vnet.ibm.com
Thu Jul 21 17:21:49 AEST 2016
Mukesh Ojha <mukesh02 at linux.vnet.ibm.com> writes:
> It replaces two letter SRC components macro name with some meaningful
> components name to make it more legible.
>
> E.g:
> OPAL_XS => OPAL_SRC_COMPONENT_XSCOM
>
> Signed-off-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>
> ---
> include/errorlog.h | 268 ++++++++++++++++++++++++++---------------------------
> 1 file changed, 134 insertions(+), 134 deletions(-)
>
> diff --git a/include/errorlog.h b/include/errorlog.h
> index 2926098..938decc 100644
> --- a/include/errorlog.h
> +++ b/include/errorlog.h
> @@ -162,173 +162,173 @@ struct opal_err_info {
> * character name in FSP and displayed.
> */
> /* SAPPHIRE components */
> -#define OPAL_CODEUPDATE 0x4355 /* CU */
> -#define OPAL_CONSOLE 0x434E /* CN */
> -#define OPAL_CEC 0x4345 /* CE */
> -#define OPAL_CHIP 0x4348 /* CH */
> -#define OPAL_ELOG 0x454C /* EL */
> -#define OPAL_NVRAM 0x4E56 /* NV */
> -#define OPAL_RTC 0x5254 /* RT */
> -#define OPAL_SURVEILLANCE 0x5355 /* SU */
> -#define OPAL_SYSPARAM 0x5350 /* SP */
> -#define OPAL_LPC 0x4C50 /* LP */
> -#define OPAL_UART 0x5541 /* UA */
> -#define OPAL_OCC 0x4F43 /* OC */
> -#define OPAL_OP_PANEL 0x4F50 /* OP */
> -#define OPAL_PHB3 0x5048 /* PH */
> -#define OPAL_PSI 0x5053 /* PS */
> -#define OPAL_VPD 0x5650 /* VP */
> -#define OPAL_XSCOM 0x5853 /* XS */
> -#define OPAL_PCI 0x5043 /* PC */
> -#define OPAL_MISC 0x4D49 /* MI */
> -#define OPAL_ATTN 0x4154 /* AT */
> -#define OPAL_MEM_ERR 0x4D45 /* ME */
> -#define OPAL_CENTAUR 0x4354 /* CT */
> -#define OPAL_MFSI 0x4D46 /* MF */
> -#define OPAL_DUMP 0x4455 /* DU */
> -#define OPAL_LED 0x4C45 /* LE */
> -#define OPAL_SENSOR 0x5345 /* SE */
> -#define OPAL_SLW 0x534C /* SL */
> -#define OPAL_FSP 0x4650 /* FP */
> -#define OPAL_I2C 0x4943 /* IC */
> -#define OPAL_IPMI 0x4950 /* IP */
> +#define OPAL_CODEUPDATE 0x4355
> +#define OPAL_CONSOLE 0x434E
> +#define OPAL_CEC 0x4345
> +#define OPAL_CHIP 0x4348
> +#define OPAL_ELOG 0x454C
> +#define OPAL_NVRAM 0x4E56
> +#define OPAL_RTC 0x5254
> +#define OPAL_SURVEILLANCE 0x5355
> +#define OPAL_SYSPARAM 0x5350
> +#define OPAL_LPC 0x4C50
> +#define OPAL_UART 0x5541
> +#define OPAL_OCC 0x4F43
> +#define OPAL_OP_PANEL 0x4F50
> +#define OPAL_PHB3 0x5048
> +#define OPAL_PSI 0x5053
> +#define OPAL_VPD 0x5650
> +#define OPAL_XSCOM 0x5853
> +#define OPAL_PCI 0x5043
> +#define OPAL_MISC 0x4D49
> +#define OPAL_ATTN 0x4154
> +#define OPAL_MEM_ERR 0x4D45
> +#define OPAL_CENTAUR 0x4354
> +#define OPAL_MFSI 0x4D46
> +#define OPAL_DUMP 0x4455
> +#define OPAL_LED 0x4C45
> +#define OPAL_SENSOR 0x5345
> +#define OPAL_SLW 0x534C
> +#define OPAL_FSP 0x4650
> +#define OPAL_I2C 0x4943
> +#define OPAL_IPMI 0x4950
the above hunk seems to remove a bit of info, namely what the 0xXXXX
maps to (in ascii). I'd prefer to keep the ASCII there so that we know
the convention.
--
Stewart Smith
OPAL Architect, IBM.
More information about the Skiboot
mailing list