[Skiboot] [PATCH v2 3/3] platform/mambo add a heartbeat timer

[Michael Neuling]

On Thu, 2016-07-21 at 15:58 +1000, Chris Smart wrote:
> The console is very slow when using Skiboot with Mambo.
> 
> This adds a heartbeat timer as a platform quirk so that the console is
> refresh more quickly. This results in Skiboot doing the right thing
> without requiring custom settings in skiboot.tcl files.



> 
> Signed-off-by: Chris Smart <chris at distroguy.com>
> ---
>  platforms/mambo/mambo.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/platforms/mambo/mambo.c b/platforms/mambo/mambo.c
> index 69e0796791a8..cb1bb4d9a2e8 100644
> --- a/platforms/mambo/mambo.c
> +++ b/platforms/mambo/mambo.c
> @@ -259,6 +259,11 @@ static int mambo_nvram_start_read(void *dst,
> uint32_t src, uint32_t len)
>  	return OPAL_SUCCESS;
>  }
>  
> +static int mambo_heartbeat_timer(void)
> +{
> +	return 100;
> +}

Can you add a comment here as to why?  Something like what you have in the
commit message:

    mambo is slow and has no console input interrupt so needs to poll
    quickly to make the console interactivity decent.

> +
>  DECLARE_PLATFORM(mambo) = {
>  	.name			= "Mambo",
>  	.probe			= mambo_probe,
> @@ -269,4 +274,5 @@ DECLARE_PLATFORM(mambo) = {
>  	.nvram_start_read	= mambo_nvram_start_read,
>  	.start_preload_resource	= flash_start_preload_resource,
>  	.resource_loaded	= flash_resource_loaded,
> +	.heartbeat_timer	= mambo_heartbeat_timer,
>  };