[Skiboot] [PATCH stable 5.1.x 1/3] xscom: Return OPAL_WRONG_STATE on XSCOM ops if CPU is asleep

Stewart Smith stewart at linux.vnet.ibm.com
Thu Jul 21 13:53:19 AEST 2016


Vipin K Parashar <vipin at linux.vnet.ibm.com> writes:
> From: Russell Currey <ruscur at russell.cc>
>
> xscom_read and xscom_write return OPAL_SUCCESS if they worked, and
> OPAL_HARDWARE if they didn't.  This doesn't provide information about why
> the operation failed, such as if the CPU happens to be asleep.
>
> This is specifically useful in error scanning, so if every CPU is being
> scanned for errors, sleeping CPUs likely aren't the cause of failures.
>
> So, return OPAL_WRONG_STATE in xscom_read and xscom_write if the CPU is
> sleeping.
>
> Signed-off-by: Russell Currey <ruscur at russell.cc>
> Reviewed-by: Alistair Popple <alistair at popple.id.au>
> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
> (cherry picked from commit 9c2d82394fd2303847cac4a665dee62556ca528a)
> Signed-off-by: Vipin K Parashar <vipin at linux.vnet.ibm.com>
> ---
>  doc/opal-api/opal-xscom-read-write-65-66.txt |  5 +++++
>  hw/xscom.c                                   | 29 +++++++++++++++++-----------
>  2 files changed, 23 insertions(+), 11 deletions(-)

series merged to 5.1.x as of 7672009

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list