[Skiboot] [PATCH V2 2/2] platforms/ibm-fsp: Use power_ctl bit when determining slot reset method

Suraj Jitindar Singh sjitindarsingh at gmail.com
Tue Jul 19 12:01:51 AEST 2016

On 19/07/16 11:58, Russell Currey wrote:
> On Tue, 2016-07-19 at 11:18 +1000, Suraj Jitindar Singh wrote:
>> Previously the power_clt bit provided by the VPD was unused, now that we
>                  ^
>                    TYPO NAK NAK NAK

Patch was insufficiently bikeshedded

>> are correctly assigning it we can use it when determining the slot reset
>> method.
>> The power_ctl bit is used to represent if power management is available.
>> If power_ctl is set to true, then the I2C based external power management
>> functionality will be populated on the PCI slot. Otherwise we will try to
>> use the inband PERST as the fundamental reset, as before.
>> While we are here we introduce a helper function to isolate the logic
>> initialisation for the I2C based external power management, to improve
>> readibility.
>> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh at gmail.com>
>> Acked-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
>> ---
> Much better!
> Reviewed-by: Russell Currey <ruscur at russell.cc>
> Stewart can probably fix the typo when applying, assuming noone has further
> comments that would require a v3.

More information about the Skiboot mailing list