[Skiboot] [PATCH] Stop adding legacy linux, phandle to device tree, just add phandle

Stewart Smith stewart at linux.vnet.ibm.com
Fri Jul 15 15:52:07 AEST 2016


Since the very first commit of a skeleton powernv platform in Linux,
the kernel has been able to deal with phandle rather than linux,phandle.

Thus, every kernel in the real world that has a hope of even getting to
a twinkle in the eye of booting knows about phandle.

So, we don't need to add linux,phandle along with phandle as it's just
redundantly redundant.

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 core/fdt.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/core/fdt.c b/core/fdt.c
index a22a84028217..79122b7cdddb 100644
--- a/core/fdt.c
+++ b/core/fdt.c
@@ -55,11 +55,6 @@ static void dt_begin_node(void *fdt, const struct dt_node *dn)
 {
 	save_err(fdt_begin_node(fdt, dn->name));
 
-	/*
-	 * We add both the new style "phandle" and the legacy
-	 * "linux,phandle" properties
-	 */
-	dt_property_cell(fdt, "linux,phandle", dn->phandle);
 	dt_property_cell(fdt, "phandle", dn->phandle);
 }
 
-- 
2.1.4



More information about the Skiboot mailing list