[Skiboot] [PATCH 1/3] errorlog : Fixes duplicate use of SRC component ID's

[Stewart Smith]

Mukesh Ojha <mukesh02 at linux.vnet.ibm.com> writes:
> On Thursday 14 July 2016 01:35 PM, Stewart Smith wrote:
>> Mukesh Ojha <mukesh02 at linux.vnet.ibm.com> writes:
>>> Same SRC component id was used for two components. This patch fixes it and allocate
>>> them unused component id's.
>>>
>>> Signed-off-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>
>> So, I had a look at the other defines around here, put them in order and
>> noticed another duplicate:
>>
>> #define OPAL_CU                         0x1000
>> #define OPAL_VP                         0x1000
>> and
>> #define OPAL_SE                         0x2000
>> #define OPAL_CN                         0x2000
>>
>> So, what I've done is re-ordered the table into numerical order.
>>
>> Then, finding that OPAL_VP was unused, I just changed it to a free
>> number 0x1a00, same with OPAL_CN (now 0x1b00).
>>
>> I don't particularly like the two letter codes there though.. they're
>> not obvious as to what they are. A patch to change them to be something
>> like OPAL_SRC_COMPONENT_XSCOM would be welcome.
>>
>
> Will send the patch addressing your concern.
> It would also be good, if we add a comment saying
> SRC code from 0X1c00 to 0x1f00 and 0x2500 to 0x2f00 are unused.

I think it's implied that they're unused in the absence of a
comment/define saying they're reserved.

-- 
Stewart Smith
OPAL Architect, IBM.