[Skiboot] [PATCH V3 4/6] opal/errorlog : Generalize the errorlog read path
hegdevasant at linux.vnet.ibm.com
Wed Jul 13 19:34:47 AEST 2016
On 06/30/2016 02:40 PM, Stewart Smith wrote:
> Mukesh Ojha <mukesh02 at linux.vnet.ibm.com> writes:
>> Introduces platform hooks for errorlog info, read, ack, and resend pending logs
>> by adding four new function pointers in the platform structure.
>> Adds opal generic function for read, info, ack and resend pending logs as
>> callback, which will be called from kernel.
>> Moving the opal call registration from fsp-elog-read.c to core/elog-host.c
>> and the calling the fsp specific function via platform hooks, which will
>> be initialised once the platform is known, otherwise it will be NULL.
>> Declarations of fsp specific routine are kept in fsp-elog.h .
> What would the platform implementation look like if there was a flash
> backed store? Or just memory (we could do this for mambo/qemu)?
We are letting platform code to decide on how it wants to write error log.
In case of FSP system, we just write error to FSP and FSP will resend all those
errors to host again.
And in BMC case, we write to both BMC and host simultaneously (.. as BMC will
not resend those errors).
So we just need to implement elog_commit hook in platform code so that it can
write to backend storage and send error to host.
> In fact, adding mambo platform support for it would be excellent.
Yep. Once this patchset in merged we will add mambo backend it will write error
logs to host.
More information about the Skiboot