[Skiboot] [PATCH 2/3] doc/errorlogging : Update details about error logging on FSP and BMC

[Vasant Hegde]

On 07/13/2016 10:58 AM, Mukesh Ojha wrote:
> This patch add more description and example how errorlogging is independent of
> the platform and also talks about how errorlogs committed on BMC systems.
>
> Signed-off-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>
> ---
>   doc/error-logging.txt | 48 ++++++++++++++++++++++++++++++++++++++++--------
>   1 file changed, 40 insertions(+), 8 deletions(-)
>
> diff --git a/doc/error-logging.txt b/doc/error-logging.txt
> index 7c62520..db03046 100644
> --- a/doc/error-logging.txt
> +++ b/doc/error-logging.txt
> @@ -178,16 +178,48 @@ Step 2: Data can be appended to the user data section using the either of
>   	uint32_t tag: Unique value to identify the data.
>                          Ideal to have ASCII value for 4-byte string.
>
> -Step 3: Once all the data for an error is logged in, the error needs to be
> -	committed in FSP.
> +Step 3: There is a platform hook for the opal errorlog to be committed both on
> +	FSP and BMC based machines.

Any platform can implement this hook. Today FSP and BMC platforms are making use 
of this hook.
>
> -	rc = elog_fsp_commit(buf);
> +	FSP:
> +		.elog_commit            = elog_fsp_commit
> +
> +	Once all the data for an error is logged in, the error needs to
> +	be committed in FSP.
> +
> +	rc = platform.elog_commit(elog);
>   	Value of 0 is returned on success.
>
> -In the process of committing an error to FSP, log info is first internally
> -converted to PEL format and then pushed to the FSP. All the errors logged
> -in Sapphire are again pushed up to POWERNV platform by the FSP and all the errors
> -reported by Sapphire and POWERNV are logged in FSP.
> +	In the process of committing an error to FSP, log info is first
> +	internally converted to PEL format and then pushed to the FSP. All the
> +	errors logged in Sapphire are again pushed up to POWERNV platform by the
> +	FSP and all the errors reported by Sapphire and POWERNV are logged in
> +	FSP.

I think we should reword this little bit.

Once OPAL sends error log to FSP, FSP will take care of sending errors to host. 
Hence OPAL will not send errors to host. OPAL maintains timeout field for all 
errors it is sending to FSP. If FSP didn't ACK the log without timeout period 
(say FSP was down), then OPAL will send those errors to host.




> +
> +	BMC:
> +		.elog_commit            = ipmi_elog_commit
> +
> +	rc = platform.elog_commit(elog);
> +	Value of 0 is returned on success.
> +
> +	In case of BMC machines, errorlogs are committed to the BMC via IPMI
> +	interface. Errorlogs are first converted to ESEL format then sent to

May be we should mention that  in our case , eSEL = SEL header + PEL

-Vasant